-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrangler-groupBy e2e #667
wrangler-groupBy e2e #667
Conversation
c88737f
to
f237d3b
Compare
f237d3b
to
f43df1a
Compare
f43df1a
to
5e7ddd8
Compare
f7d1e29
to
ad7736c
Compare
8fb1bd9
to
4fecb5e
Compare
4fecb5e
to
4285001
Compare
31c4e2c
to
2014fdf
Compare
pom.xml
Outdated
@@ -83,7 +83,7 @@ | |||
<aws.sdk.version>1.11.133</aws.sdk.version> | |||
<bigquery.connector.hadoop2.version>0.10.2-hadoop2</bigquery.connector.hadoop2.version> | |||
<bouncycastle.version>1.56</bouncycastle.version> | |||
<cdap.version>6.10.0-SNAPSHOT</cdap.version> | |||
<cdap.version>6.11.0-SNAPSHOT</cdap.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar comment like other PRs, change it to 6.10.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to 6.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
"label": "Wrangler", | ||
"artifact": { | ||
"name": "wrangler-transform", | ||
"version": "4.10.0-SNAPSHOT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can pass range of plugin here, so that it picks up latest otherwise we will need to always keep changing the version here when plugin version is changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to the latest versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
"label": "BigQueryTable", | ||
"artifact": { | ||
"name": "google-cloud", | ||
"version": "0.23.0-SNAPSHOT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar comment here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use range of version in plugin versions and cdap data pipeline artifact version in the pipeline jsons otherwise we will need to always keep modifying the pipeline.
3ec8f59
to
27ac295
Compare
484dfe8
to
e20018d
Compare
e20018d
to
bef211e
Compare
e2e test for BQ to BQ using wrangler-groupBy plugin